Re: [PATCH] Permissions don't stick on ConfigFS attributes

[Greg KH]

On Sat, Aug 20, 2005 at 10:50:51AM +1000, Daniel Phillips wrote:
> Hi Joel,
> 
> Permissions set on ConfigFS attributes (aka files) do not stick.

The recent changes to sysfs should be ported to configfs to do this.

> So: Integrate with sysfs.

No, don't.  Do you think that Joel would not have already worked with
the sysfs people prior to submitting this?  No, he did, and we all
agreed that it should be kept separate.

> Terminology skew.  It is a very bad idea to call your configfs files 
> "attributes".

That's what sysfs calls its files.  They used the same naming scheme
there.  This is nothing that a user ever cares about or sees.

> Memory requirements.  ConfigFS pins way too much kernel memory for inodes
> and dentries.

configfs is not going to have that many nodes at all in memory (compared
to sysfs), so I don't think this is a big problem.

> Verbose kernel side interfaces.  My kernel-side implementation of a very 
> simple group with single-attribute children is about 150 lines.  If this 
> interface takes off and there are, say, 100 kernel classes exposed via 
> configfs, is 15,000 lines of kernel source an acceptable overhead?  Not in my 
> book.  You need a libconfigfs to encapsulate some of the more common 
> situations so that a kernel-side interface can be just half a dozen lines or 
> so in those cases.  Of course, it would help to use this a while and find out 
> what those common situations really are.

So we wait and evolve the interface over time.  Like always...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/