Re: [2.6 patch] fs/adfs/adfs.h: "extern inline" doesn't make sense

[Adrian Bunk]

On Sun, Aug 21, 2005 at 02:56:40PM +0200, Pierre Ossman wrote:
> Adrian Bunk wrote:
> > [ this time with a better subject ]
> > 
> > "extern inline" doesn't make sense.
> > 
> > 
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> > 
> 
> Isn't 'extern inline' an old gcc trick to force inlining? (instead of
> just hinting)

For gcc >= 3.1, we are already telling the compiler that it should 
either inline the code or abort compilation.

"extern inline" doesn't make much sense. And it gives a warning with 
-Wmissing-prototypes.

I'm currently cleaning up warnings with -Wmissing-prototypes to get them 
to an acceptable level. -Wmissing-prototypes will help us to enforce a 
coding style that will avoid a class of nasty runtime errors that are 
currently sometimes hitting us.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/