Re: suspicious behaviour in pcwd driver.

[Dave Jones]

On Mon, Aug 22, 2005 at 02:30:06PM -0400, Dave Jones wrote:
 > drivers/char/watchdog/pcwd.c does this if it detects
 > a temperature out of range..
 > 
 >             if (temp_panic) {
 >                 printk (KERN_INFO PFX "Temperature overheat trip!\n");
 >                 machine_power_off();
 >             }
 > 
 > Two problems here are..
 > 
 > 1. machine_power_off() isn't exported on ppc64. (patch below)

I was looking at an old tree, and this is now kernel_power_off()
so this isn't a problem for pcwd, however the export is still needed
for drivers/macintosh/therm_pm72.c

 > 2. that printk will never hit the logs, so the admin will just find
 > a powered off box with no idea what happened.
 > Should we at least sync block devices before doing the power off ?

AFAICS, this is still a problem with kernel_power_off() though ?

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/