Re: [RFC] [patch 0/39] remap_file_pages protection support, try 2

[Blaisorblade]

On Friday 12 August 2005 22:52, Andi Kleen wrote:
> Blaisorblade <blaisorblade@xxxxxxxx> writes:
> > Ok, I've been working for the past two weeks learning well the Linux VM,
> > understanding the Ingo's remap_file_pages protection support and its
> > various weakness (due to lack of time on his part), and splitting and
> > finishing it.

> I'm not sure remap_file_pages was ever intended to be more integrated.
> It pretty much always was a Oracle specific performance hack. The problem
> with making it more powerful is that it will become more invasive then
> (like your patchbomb shows)

(Note that it's probably even *too* subtly splitout).

> and that will make it a bigger maintenance 
> issue longer term and complicate all of VM. And it's probably not
> worth doing all that.

The reason for this work, this time, is for UML (it's not casual I'm working 
on it). However, it's true that what I implemented is actually more powerful 
than what's needed by UML.

It only needs (IIRC) to do void (i.e. PROT_NONE) mmaps, and then to remap from 
them changing both protections and file offset. And such mappings must 
support swapout.

This will replace the current use of mmap()/mprotect() done one page at a time 
(when the guest has more than 256 M we easily hit 
the /proc/sys/vm/max_map_count and must increase it).

I've gone implementing and fixing the general thing, including mappings where 
only the protections are changed but which are still linear.

Still, even without all this the patch will still be bigger than when it was 
in -mm last time (i.e. until 2.6.5-mm1), since that didn't handle swapout.

However, in terms of invasiveness, the changes needed to support the nonlinear 
mappings are way bigger than what's needed for protections, especially for 
nonlinear truncation.

> So in short I think it's better to keep it into its corner with minimum
> functionality and let it not expand to other parts.
Ok, I think this may be reasonable. However, for now I'm still finishing the 
full implementation, I'll start dropping pieces when we've decided what's 
needed.
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/