Re: PATCH for changing of DVD speed via ioctl() call

[Bodo Eggert]

On Sun, 21 Aug 2005, Chris Wedgwood wrote:
> On Sun, Aug 21, 2005 at 09:56:45PM +0200, Bodo Eggert wrote:

> > The parameter value should IMHO be a pointer to a struct {
> >  unsigned long long maxspeed; // (with 0 being the magic max. value?)
> >  int facility; /* 0=general speed, 2=general read, 4=read data,
> >                   6=read audio, 8=read raw ... whatever is supported
> >                   n+1 = s/read/write/ */
> > }
> 
> Passing pointers inside ioctl's is horrible IMO and if we can avoid it
> we should.  It's just asking for problems.

It's used in all ioctls not requiring a read-only int or a void. See man 
ioctl_list (2).
-- 
Top 100 things you don't want the sysadmin to say:
26. What happens to a Hard Disk when you drop it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/