Re: [patch 8/8] [PATCH] Module per-cpu alignment cannot always be met

[Denis Vlasenko]

On Friday 12 August 2005 01:54, Chris Wright wrote:
> -stable review patch.  If anyone has any  objections, please let us know.
> ------------------
> 
> The module code assumes noone will ever ask for a per-cpu area more than
> SMP_CACHE_BYTES aligned.  However, as these cases show, gcc asks sometimes
> asks for 32-byte alignment for the per-cpu section on a module, and if
> CONFIG_X86_L1_CACHE_SHIFT is 4, we hit that BUG_ON().  This is obviously an
> unusual combination, as there have been few reports, but better to warn
> than die.

gcc gets increasingly sadistic about alignment:

"char global_var[] = "larger than 32 bytes"; uses silly amounts of alignment even with -Os"
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22158

Please, everybody who thinks that _32_ _byte_ alignment
is outright silly, add your comments to this bugzilla entry.
--
vda

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/