Re: [PATCH 2.6.12.5]fix gl_skb/skb type error in genelink driver in usbnet in 2.6

[David Brownell]

>    I think there is a type error when port genelink driver to 2.6..
>    With this error, a linux host will panic when it link with a windows
>    host.
>    
>    See the following patch.
>

Looks right to me; thanks!  Would you happen to know if this
GL620a chip is still manufactured?

If this oops fix doesn't make 2.6.13, I'll roll this change into
the upcoming split of "usbnet" into eight minidrivers around a
shared core library.

- Dave


> --- linux-2.6-curr/drivers/usb/net/usbnet.c	2005-06-30 07:00:53.000000000 +0800
> +++ linux-2.6-curr-lepton/drivers/usb/net/usbnet.c	2005-08-22 13:55:18.000000000 +0800
> @@ -1922,7 +1922,7 @@ static int genelink_rx_fixup (struct usb
>  
>  			// copy the packet data to the new skb
>  			memcpy(skb_put(gl_skb, size), packet->packet_data, size);
> -			skb_return (dev, skb);
> +			skb_return (dev, gl_skb);
>  		}
>  
>  		// advance to the next packet
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/