Re: [RFC: 2.6 patch] fs/super.c: unexport user_get_super

From: Christoph Hellwig
Date: Tue Aug 23 2005 - 04:57:20 EST


On Mon, Aug 22, 2005 at 06:20:56PM +0200, Adrian Bunk wrote:
> I didn't find any modular usage in the kernel.

And there shouldn't be one either. This is really just for some syscalls,
everything else should use get_super based on a struct block_device. If
there's any caller using this wrongly in out of tree modules they can
be switched to bdget + get_super trivially (fixing their code would be
even better).

> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> ---
>
> This patch was already sent on:
> - 30 May 2005
> - 13 May 2005
> - 1 May 2005
> - 23 Apr 2005
>
> --- linux-2.6.12-rc2-mm3-full/fs/super.c.old 2005-04-23 02:45:59.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/fs/super.c 2005-04-23 02:46:07.000000000 +0200
> @@ -467,8 +467,6 @@
> return NULL;
> }
>
> -EXPORT_SYMBOL(user_get_super);
> -
> asmlinkage long sys_ustat(unsigned dev, struct ustat __user * ubuf)
> {
> struct super_block *s;
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---end quoted text---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/