Re: CFQ + 2.6.13-rc4-RT-V0.7.52-02 = BUG: scheduling with irqs disabled

[Ingo Molnar]

* Esben Nielsen <simlo@xxxxxxxxxx> wrote:

> Yes, spin_lock(lock) is blocking since lock is mutex, not a spinlock 
> under preempt-rt. But isn't it easy to fix? Replace the two lines by 
> spin_lock_irqsave(flags). That would work for both preempt-rt and 
> !preempt-rt.

at this moment we do not pester upstream developers with PREEMPT_RT 
details. It is not at all clear at this moment whether and if how any 
API changes will look like. So there's nothing "to fix" at all!!

for the cases where there's a clear cleanup potential from merging flags 
and locks management we submit separate patches, which stand on their 
own. It happened already, and it will happen in the future. The rest 
Jens does not need to care about.

_often_, trouble on the PREEMPT_RT side highlights some potential 
trouble on the upstream side. Unclean locking rules, unecessary/unsafe 
disabling of interrupts, etc. But no way is there a 1:1 relationship.  
E.g. in this particular case i already fixed the warning in the current 
-RT tree.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/