Re: [PATCH] (18/22) task_thread_info - part 2/4

[Roman Zippel]

Hi,

On Thu, 25 Aug 2005, Al Viro wrote:

>  
> +static inline void setup_thread_info(struct task_struct *p, struct thread_info *ti)
> +{
> +	*ti = *p->thread_info;
> +}
> +
>  
> -	*ti = *orig->thread_info;
>  	*tsk = *orig;
> +	setup_thread_info(tsk, ti);
>  	tsk->thread_info = ti;
>  	ti->task = tsk;

This introduces a subtle ordering requirement, where setup_thread_info 
magically finds in the new task_struct the pointer to the old thread_info 
to setup the new thread_info.
What is your problem with what I have in CVS? There it completes the basic
task_struct setup and _after_ that it can setup the thread_info.

Al, I would really prefer to merge this one myself, I'm only waiting for 
the 2.6.13 release and since this is not a regression, I don't really 
understand why this must be in 2.6.13.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/