Re: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll

[Pekka J Enberg]

Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> > This patch changes fifo_poll not to return POLLERR to take care of a FIXME
> > in fs/pipe.c stating that "Most unices do not set POLLERR for fifos." The
> > comment has been there since 2.3.99-pre3 so either apply this patch or
> > alternatively, I can send a new one removing the unnecessary abstraction.

On Thu, 25 Aug 2005, Andrew Morton wrote:
> A userspace-visible change, no?
> 
> So there's a risk in changing it.  What do we get in return?  Worried.

FWIW I have been running on this for few days now without any noticeable 
regressions.  We get a solved FIXME in return but like I said I am a happy 
to remove the redundant abstraction if this is too risky.

			Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/