Re: [patch] IBM HDAPS accelerometer driver.

[Robert Love]

On Fri, 2005-08-26 at 14:27 -0500, Dmitry Torokhov wrote:

> What this completion is used for? I don't see any other references to it.

It was the start of the release() routine, but I decided to move to
platform_device_register_simple() and use its release, instead.  So this
is gone now in my tree.

> I'd rather you used absolute coordinates and set up
> hdaps_idev->absfuzz to do the filtering.

Me too.

> This is racy - 2 threads can try to do this simultaneously.

Fixed.  Thanks.

> > +
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_position);
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_variance);
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_temp);
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_calibrate);
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_mousedev);
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_mousedev_threshold);
> > +       device_create_file(&hdaps_plat_dev.dev, &dev_attr_mousedev_poll_ms);
> > +
> 
> What about using sysfs_attribute_group?

I don't see this in my tree?

	Robert Love


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/