Re: Why is kmem_bufctl_t different across platforms?

[Kyle Moffett]

On Aug 28, 2005, at 19:37:16, Adrian Bunk wrote:
> On Sun, Aug 28, 2005 at 02:55:03PM -0700, Andrew Morton wrote:
> > Kyle Moffett <mrmacman_g4@xxxxxxx> wrote:
> > > While exploring the asm-*/types.h files, I discovered that the
> > >  type "kmem_bufctl_t" is differently defined across each platform,
> > >  sometimes as a short, and sometimes as an int.  The only file
> > >  where it's used is mm/slab.c, and as far as I can tell, that file
> > >  doesn't care at all, aside from preferring it to be a small-sized
> > >  type.
> >
> > I don't think there's any good reason for this.  -mm's
> > slab-leak-detector.patch switches them all to unsigned long.
>
> What about moving it to include/linux/types.h ?

Or, since it's _only_ used in mm/slab.c, why not put it in there?
Here is a really simple patch that does just that:

Attachment: kmem_bufctl_t-consolidation.patch
Description: Binary data

Cheers,
Kyle Moffett

--
Q: Why do programmers confuse Halloween and Christmas?
A: Because OCT 31 == DEC 25.