Re: [PATCH] custom PM support for 8250

[Russell King]

On Wed, Aug 31, 2005 at 03:10:09PM +0400, Vitaly Wool wrote:
> please find the patch that allows passing the pointer to custom power 
> management routine (via platform_device) to 8250 serial driver.
> Please note that the interface to the outer world (i. e. exported 
> functions) remained the same.

I'd rather change the structure passed via the platform device to
something like:

struct platform_serial_data {
	void	(*pm)(struct uart_port *port, unsigned int state, unsigned int old);
	int	nr_ports;
	struct plat_serial8250_port *ports;
};

which also eliminates the empty plat_serial8250_port terminator from
all the serial8250 platform devices (which appears to have caused some
folk problems.)

It does mean that a set of 8250 ports (grouped by each platform device)
have a common power management method - which seems a logical restriction.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/