Re: [linux-dvb-maintainer] [2.6 patch] add missing select's to DVB_BUDGET_AV

From: Adrian Bunk
Date: Wed Aug 31 2005 - 12:10:03 EST


On Wed, Aug 31, 2005 at 06:59:07PM +0200, Johannes Stezenbach wrote:
> On Wed, Aug 31, 2005 Adrian Bunk wrote:
> >
> > Add missing select's to DVB_BUDGET_AV fixing the following compile
> > error:
> >
> > <-- snip -->
> >
> > ...
> > LD .tmp_vmlinux1
> > drivers/built-in.o: In function `frontend_init':
> > budget-av.c:(.text+0xb9448): undefined reference to `tda10046_attach'
> > budget-av.c:(.text+0xb9518): undefined reference to `tda10021_attach'
> > drivers/built-in.o: In function `philips_tu1216_request_firmware':
> > budget-av.c:(.text+0xb937b): undefined reference to `request_firmware'
> > make: *** [.tmp_vmlinux1] Error 1
> >
> > <-- snip -->
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> Acked-by: Johannes Stezenbach <js@xxxxxxxxxxx>
>
> I also added this to linuxtv.org CVS. But I'm not sure it
> is critical enough to put it in stable.

If I were a -stable maintainer, I'd include both patches after they were
included in Linus' tree and shipped with one -rc or -mm kernel.

But that's not a strong opinion, it's also OK for me if the patches
don't get included in 2.6.13.x .

> Thanks,
> Johannes
>...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/