Re: [PATCH 07/11] memory hotplug: sysfs and add/remove functions

[Dave Hansen]

On Fri, 2005-09-02 at 15:13 -0700, Andrew Morton wrote:
> Dave Hansen <haveblue@xxxxxxxxxx> wrote:
> >
> > +		for (i = 0; i < PAGES_PER_SECTION; i++) {
> > +			if (PageReserved(first_page+i))
> > +				continue;
> 
> How intimate do these patches get with PageReserved()?  Bear in mind that
> we're slowly working toward making PageReserved go away.

It's basically the same way that the init code uses it.  When
initialized, a struct page has it set.  In theory, an architecture could
decide to keep the bit set when it is doing online_pages().  However, I
don't think any do that today.  Nobody would really notice if we killed
that.  That check could probably instead be something like
page_is_ram().

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/