Re: [PATCH] more of sparc32 dependencies fallout

[viro]

On Fri, Sep 02, 2005 at 01:03:43PM -0700, David S. Miller wrote:
> From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] more of sparc32 dependencies fallout
> Date: Fri, 02 Sep 2005 21:24:08 +0100
> 
> > On Gwe, 2005-09-02 at 20:12 +0100, viro@xxxxxxxxxxxxxxxxxx wrote:
> > >  config MOXA_SMARTIO
> > >  	tristate "Moxa SmartIO support"
> > > -	depends on SERIAL_NONSTANDARD
> > > +	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
> > >  	help
> > 
> > 
> > Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its
> > only available as a plugin card and its apparently working
> 
> He marked it BROKEN "OR" !SPARC32, not "AND".
> Also, SPARC32 supports PCI on Javastation machines.

Actually, proper fix of that breakage is embarrassingly simple - it's yet
another gratitious leftover include of asm/segment.h, so incremental to the
previos would be removal of that BROKEN and removal of bogus include from
mxser.c itself.

diff -urN RC13-git3-base/drivers/char/Kconfig current/drivers/char/Kconfig
--- RC13-git3-base/drivers/char/Kconfig	2005-09-02 14:16:04.000000000 -0400
+++ current/drivers/char/Kconfig	2005-09-02 19:20:11.000000000 -0400
@@ -175,7 +175,7 @@
 
 config MOXA_SMARTIO
 	tristate "Moxa SmartIO support"
-	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
+	depends on SERIAL_NONSTANDARD
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card.
 
diff -urN RC13-git3-base/drivers/char/mxser.c current/drivers/char/mxser.c
--- RC13-git3-base/drivers/char/mxser.c	2005-06-17 15:48:29.000000000 -0400
+++ current/drivers/char/mxser.c	2005-09-02 19:20:05.000000000 -0400
@@ -63,7 +63,6 @@
 #include <asm/system.h>
 #include <asm/io.h>
 #include <asm/irq.h>
-#include <asm/segment.h>
 #include <asm/bitops.h>
 #include <asm/uaccess.h>
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/