Re: [DVB patch 23/54] usb: add TwinhanDTV StarBox support

[Nish Aravamudan]

On 9/4/05, Johannes Stezenbach <js@xxxxxxxxxxx> wrote:
> From: Patrick Boettcher <pb@xxxxxxxxxxx>
> 
> Add driver for the TwinhanDTV StarBox and clones.
> 
> Thanks to Ralph Metzler for his initial work on this box and thanks to Twinhan
> for their support.

<snip>

> --- /dev/null   1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6.13-git4/drivers/media/dvb/dvb-usb/vp702x-fe.c     2005-09-04 22:28:15.000000000 +0200

<snip>

> +static int vp702x_fe_refresh_state(struct vp702x_fe_state *st)
> +{
> +       u8 buf[10];
> +       if (time_after(jiffies,st->next_status_check)) {
> +               vp702x_usb_in_op(st->d,READ_STATUS,0,0,buf,10);
> +
> +               st->lock = buf[4];
> +               vp702x_usb_in_op(st->d,READ_TUNER_REG_REQ,0x11,0,&st->snr,1);
> +               vp702x_usb_in_op(st->d,READ_TUNER_REG_REQ,0x15,0,&st->sig,1);
> +
> +               st->next_status_check = jiffies + (st->status_check_interval*HZ)/1000;

Should this be

st->next_status_check = jiffies + msecs_to_jiffies(st->status_check_interval);

?

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/