Re: [PATCH] ipw2200: Missing kmalloc check

From: Takis
Date: Mon Sep 05 2005 - 09:26:56 EST


On 9/5/05, Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> > rxq = (struct ipw_rx_queue *)kmalloc(sizeof(*rxq), GFP_KERNEL);
> >+ if (unlikely(!rxq)) {
> >+ IPW_ERROR("memory allocation failed\n");
> >+ return NULL;
> >+ }
> > memset(rxq, 0, sizeof(*rxq));
> >
> >
> and use kzalloc instead of kmalloc and memset 0?

Yes, but Morton's tree hasn't got the ipw2200 yet, while Linus'
Linux-tree hasn't pulled in the patches containing kzalloc. I'll send
a new patch as soon as the kzalloc patch get in Linus' tree or ipw in
Marton's.

With friendly regards,
Takis
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/