Re: [PATCH] Omnikey Cardman 4000 driver

[Nish Aravamudan]

On 9/5/05, Harald Welte <laforge@xxxxxxxxxxxx> wrote:
> Hi!
> 
> Following-up to the Cardman 4040 driver, I'm now sumitting a driver for
> the Cardman 4000 reader.  It is, too, a PCMCIA smartcard reader and the
> predecessor of the 4040.
> 
> From a technical point of view, the two devices have nothing in common,
> so there is no possibility of code sharing.

<snip>

> --- /dev/null
> +++ b/drivers/char/pcmcia/cm4000_cs.c

<snip>

> +/* interruptible_pause() */
> +static inline void ipause(unsigned long amount)
> +{
> +       current->state = TASK_INTERRUPTIBLE;
> +       schedule_timeout(amount);
> +}
> +
> +/* uninterruptible_pause() */
> +static inline void upause(unsigned long amount)
> +{
> +       current->state = TASK_UNINTERRUPTIBLE;
> +       schedule_timeout(amount);
> +}

It looks like all callers of these functions pass in milliseconds? Any
chance you can get rid of these two and use msleep_interruptible() and
msleep() instead? As long as you are not using these functions around
wait-queues, you are ok (which I think is the case here). If you are
using wait-queues with these sleeps, then please use
schedule_timeout_interruptible() and
schedule_timeout_uninterruptible() from the -mm tree.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/