Re: [PATCH] Kconfig fix (BLK_DEV_FD dependencies)

From: Roman Zippel
Date: Tue Sep 06 2005 - 05:53:25 EST


Hi,

On Tue, 6 Sep 2005 viro@xxxxxxxxxxxxxxxxxx wrote:

> Sanitized and fixed floppy dependencies: split the messy dependencies for
> BLK_DEV_FD by introducing a new symbol (ARCH_MAY_HAVE_PC_FDC), making
> BLK_DEV_FD depend on that one and taking declarations of ARCH_MAY_HAVE_PC_FDC
> to arch/*/Kconfig. While we are at it, fixed several obvious cases when
> BLK_DEV_FD should have been excluded (architectures lacking asm/floppy.h
> are *not* going to have floppy.c compile, let alone work).

I'm not really a big fan of such dummy symbols, those whole point is to
only enable dependencies, but are otherwise unsused.
The basic problem is similiar to selects, that one has to grep the whole
Kconfig to find out what modifies the dependencies of a symbol.

If we really want to describe dependencies like this, I'd prefer to extend
the Kconfig syntax for this:

config FOO
allow BAR

config BAR
option hidden

The hidden option would explicitly hide the symbol, unless otherwise
allowed.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/