Re: [PATCH] PCI: Unhide SMBus on Compaq Evo N620c

From: Lee Revell
Date: Tue Sep 06 2005 - 17:43:36 EST


On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
> Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
> Intel 82855PM chipset.

> + } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {

Should unlikely() be used for cases where the conditional will be true
iff a specific piece of hardware is present? Seems like we'd always
lose.

Lee


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/