Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

[Jeff Garzik]

akpm@xxxxxxxx wrote:
> From: Pavel Machek <pavel@xxxxxx>
>
> This removes debug prints from entry/exit of functions.  Such level of
> debugging should probably be done by gdb or similar.
>
> Signed-off-by: Pavel Machek <pavel@xxxxxxx>
> Cc: Jeff Garzik <jgarzik@xxxxxxxxx>
> Cc: "James P. Ketrenos" <ipw2100-admin@xxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

NAK.  Rationale:  maintainer's choice.  Pavel doesn't get to choose the 
debugger of choice for the driver maintainer.

I do this entry/exit stuff in my net and SATA drivers; printk is my 
primary method of debugging.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/