Re: [PATCH 1/3] dynticks - implement no idle hz for x86

From: Nish Aravamudan
Date: Wed Sep 07 2005 - 13:34:20 EST


On 9/7/05, Srivatsa Vaddagiri <vatsa@xxxxxxxxxx> wrote:
> On Wed, Sep 07, 2005 at 10:27:43AM -0700, Nish Aravamudan wrote:
> > enter_all_cpus_idle() and exit_all_cpus_idle() would be better?
>
> Looks perfect.
>
> > No, I was saying what you were, if a little unclearly, so the caller
> > does something like:
> >
> > current_dyn_tick_timer->reprogram();
> > check_cpu_mask(nohz_cpu_mask);
> > if (we_are_last_idle)
> > enter_all_cpus_idle();
>
> Looks fine!

Great!

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/