Re: 8250_hp300: initialisation ordering bug

From: Russell King
Date: Wed Sep 07 2005 - 15:33:39 EST


On Wed, Sep 07, 2005 at 10:17:49PM +0200, Kars de Jong wrote:
> Yes, you are right. I am working on rewriting the driver a bit to use a
> platform device for the APCI driver, I'll take your bug report into
> account as well.

Thanks.

> On a related note: can I use the "serial8250" platform driver also for
> non-ISA devices (like my APCI platform device)? The comments in
> drivers/serial/8250.c suggest it's for ISA devices only, but I don't see
> a particular reason for not using it for my APCI devices.

The legacy platform device (serial8250_isa_devs) is for the old
legacy ISA tables, found in include/asm-*/serial.h.

Other serial8250 platform devices can be used to register other
devices - preferably groups of platform specific serial ports.

However, if you're talking about registering a set of devices
found on a different bus type (eg, PCI) then look at how 8250_pci
handles that. I'd prefer bus-specific device registration to be
done in a similar way to 8250_pci rather than creating extra
platform devices.

I hope that's clear.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/