Re: [PATCH] ppc64: iSeries early printk breakage

From: Stephen Rothwell
Date: Wed Sep 07 2005 - 20:01:42 EST


On Wed, 7 Sep 2005 06:04:36 -0500 Milton Miller <miltonm@xxxxxxx> wrote:
>
> Does anything actually break without this patch?

Yes, an iSeries box will not boot.

> My reading of unregister_console says we will acquire
> the console semaphore, walk the list, fail to find the
> console, relase the semaphore, and return.

Consider the case that console_drivers == NULL (because we have never called register_console).
unregister_console dereferences console_drivers ...

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature