Re: [PATCH] Fix ext3 warning for unused var

[Linus Torvalds]

On Sun, 9 Oct 2005, Paolo 'Blaisorblade' Giarrusso wrote:
>
> Can please someone merge this? It's the 3rd time I send it.

I don't like #ifdef's in code. 

You could just have split up the quota-specific stuff into a function of 
their own: "ext3_show_quota_options()". The patch might have been larger, 
but it would actually clean up the code rather than make it uglier.

Warnings are not a reason for ugly code.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/