Re: [linux-usb-devel] Re: [BUG/PATCH/RFC] Oops while completingasync USB via usbdevio

[Alan Stern]

On Mon, 10 Oct 2005, Harald Welte wrote:

> +	if ((!info || ((unsigned long)info != 1 &&
> +			(unsigned long)info != 2 && SI_FROMUSER(info)))
> +	    && (euid ^ p->suid) && (euid ^ p->uid)
> +	    && (uid ^ p->suid) && (uid ^ p->uid)) {

No doubt this was copied from somewhere else.  But why do people go to the
effort of confusing readers by using "^" instead of "!="?  These aren't 
bit-oriented values.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/