Re: [patch] remove gendisk->stamp_idle field
From: Jens Axboe
Date: Thu Oct 13 2005 - 14:16:28 EST
On Thu, Oct 13 2005, Chen, Kenneth W wrote:
> struct gendisk has these two fields: stamp, stamp_idle. Update to
> stamp_idle is always in sync with stamp and they are always the same.
> Therefore, it does not add any value in having two fields tracking
> same timestamp. Suggest to remove it.
>
> Also, we should only update gendisk stats with non-zero value.
> Advantage is that we don't have to needlessly calculate memory address,
> and then add zero to the content.
Acked-by: Jens Axboe <axboe@xxxxxxx>
Added to the upstream Linus branch of the block git tree.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/