Re: bug in handling of highspeed usb HID devices

From: Greg KH
Date: Thu Oct 13 2005 - 22:45:27 EST


On Fri, Oct 14, 2005 at 02:10:17AM +0000, Parag Warudkar wrote:
> >
> > Also, what device needs this patch? Is it a device that I can buy
> > today?
> >
> > thanks,
> >
> > greg k-h
>
> The patch is for hid-core.c - I don't think it is device specific -
> original problem should affect all High Speed USB HID devices.

I realize that, my point is are there any such devices out in the wild
that people can buy and use? I do not know of any.

> To summarize -
>
> Current code just looks plain wrong since the same logic is repeated
> twice - endpoint->bInterval is operated upon twice if the device is
> HIGH SPEED one.

I agree. That's wrong and should be fixed. A patch would be nice...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/