Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers

[Antonino A. Daplas]

Jesper Juhl wrote:
> This is the remaining misc drivers/ part of the big kfree cleanup patch.
> 
> Remove pointless checks for NULL prior to calling kfree() in misc files in drivers/.
> 
> 
> Sorry about the long Cc: list, but I wanted to make sure I included everyone
> who's code I've changed with this patch.
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
> ---

> --- linux-2.6.14-rc4-orig/drivers/video/i810/i810_main.c	2005-10-11 22:41:21.000000000 +0200
> +++ linux-2.6.14-rc4/drivers/video/i810/i810_main.c	2005-10-13 10:34:11.000000000 +0200
> @@ -2066,8 +2066,7 @@ static void i810fb_release_resource(stru
>  		iounmap(par->mmio_start_virtual);
>  	if (par->aperture.virtual)
>  		iounmap(par->aperture.virtual);
> -	if (par->edid)
> -		kfree(par->edid);
> +	kfree(par->edid);
>  	if (par->res_flags & FRAMEBUFFER_REQ)
>  		release_mem_region(par->aperture.physical,
>  				   par->aperture.size);

Ok with me. Thanks.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/