Re: [PATCH 08/14] Big kfree NULL check cleanup - drivers/media

[Wilson Michaels]

On Thursday 13 October 2005 02:28 pm, Jesper Juhl wrote:
> This is the drivers/media/ part of the big kfree cleanup
> patch.
>
> Remove pointless checks for NULL prior to calling kfree()
> in drivers/media/.
>
>
> Sorry about the long Cc: list, but I wanted to make sure
> I included everyone who's code I've changed with this
> patch.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
> ---
>
> Please see the initial announcement mail on LKML with
> subject "[PATCH 00/14] Big kfree NULL check cleanup"
> for additional details.
>

> linux-2.6.14-rc4-orig/drivers/media/dvb/frontends/lgdt330
>x.c	2005-10-11 22:41:09.000000000 +0200 +++
> linux-2.6.14-rc4/drivers/media/dvb/frontends/lgdt330x.c	2
>005-10-13 10:28:41.000000000 +0200 @@ -729,8 +729,7 @@
> struct dvb_frontend* lgdt330x_attach(con return
> &state->frontend;
>
>  error:
> -	if (state)
> -		kfree(state);
> +	kfree(state);
>  	dprintk("%s: ERROR\n",__FUNCTION__);
>  	return NULL;
>  }
> ---

Acked-by : Wilson Michaels <wilsonmichaels@xxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/