Re: [PATCH 7/9] mm: split page table lock

[Hugh Dickins]

On Sun, 23 Oct 2005, Andrew Morton wrote:
> Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
> 
> I'm rather surprised that no architectures are already using page.mapping,
> .index, .lru or .virtual in pte pages.

It is important that we don't corrupt .virtual.  But beyond that, why
should they use those fields?  Some were used in the pte_chains days,
and ppc held on to that usage for a while longer (to get from page
table to mm), but that is all gone now.  Unless I've missed something.

> > > ick.  I think I prefer the union, although it'll make struct page bigger
> > > for CONFIG_PREEMPT+CONFIG_SMP+NR_CPUS>=4.    hmm.
> > 
> > Hmm indeed.  Definitely not the tradeoff I chose or would choose.
> 
> It's not that bad, really.  I do think that this approach is just too
> dirty, sorry.  We can avoid it by moving something else into the union. 
> lru, perhaps?

Perhaps.  But revisiting this is not something I'm prepared to rush
into overnight - right answers come slower.  I'd rather we start with
what I had, tested on few architectures as it is, and consider how to
robustify it more sedately.

Or, if you prefer, disable the split (raise Kconfig default to "4096"), or
back out the 7/9 for the moment; though I had been hoping for exposure.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/