Re: [PATCH 02/02] cpuset automatic numa mempolicy rebinding

[Dave Hansen]

On Mon, 2005-10-24 at 07:47 -0700, Paul Jackson wrote:
> Dave wrote:
> > Just think how that looks to a reviewer without the full context :)
> 
> I was just copying Andi's coding style for these cases, with
> this BUG() if no policy matched.  When in Rome, do as the
> Romans.
> 
> > Perhaps the MBOL_BIND case needs a little helper function.
> 
> Eh ... that entire routine still fits on a page of my screen.
> I'm not sure that adding a helper function would clarify the
> code any.
> 
> Thanks for looking at it.  If you're pretty sure I should change
> one of the above, squeek a little louder.

I really just meant it was hard to read having two braces at the same
level.  This was due to the extra block inside of the switch() for the
'case MPOL_BIND:'.  Not a huge deal, but it did cause me a bit of a
brain fault for a moment.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/