Re: [BUG] 2.6.14-rc5-mm1 build fails for non SMP systems

From: Peter Williams
Date: Mon Oct 24 2005 - 20:43:12 EST


Peter Williams wrote:
Without CONFIG_DEBUG_SPINLOCK configured in I'm getting a large number of "implicit declaration of function ‘__raw_read_unlock’" warnings and a subsequent failure at the link stage.

A trivial change to include/linux/spinlock_up.h (i.e. moving the definition of __raw_read_unlock() outside the ifdef) can get rid of this warning but I'm not sure that it's the right thing to do as I suspect this may be an indication of a less trivial problem elsewhere.

Further investigation reveals a number of similar warnings for __raw_write_unlock() and the following failure in the ipv4 code:

In file included from /home/peterw/wrk/PlugSched/MM-2.6.14/include/linux/mroute.h:130,
from /home/peterw/wrk/PlugSched/MM-2.6.14/net/ipv4/route.c:90:
/home/peterw/wrk/PlugSched/MM-2.6.14/include/net/sock.h: In function ‘sk_dst_get’:
/home/peterw/wrk/PlugSched/MM-2.6.14/include/net/sock.h:972: warning: implicit declaration of function ‘__raw_read_unlock’
/home/peterw/wrk/PlugSched/MM-2.6.14/include/net/sock.h: In function ‘sk_dst_set’:
/home/peterw/wrk/PlugSched/MM-2.6.14/include/net/sock.h:991: warning: implicit declaration of function ‘__raw_write_unlock’
/home/peterw/wrk/PlugSched/MM-2.6.14/net/ipv4/route.c: In function ‘rt_check_expire’:
/home/peterw/wrk/PlugSched/MM-2.6.14/net/ipv4/route.c:663: warning: dereferencing ‘void *’ pointer
/home/peterw/wrk/PlugSched/MM-2.6.14/net/ipv4/route.c:663: error: request for member ‘raw_lock’ in something not a structure or union
make[3]: *** [net/ipv4/route.o] Error 1
make[2]: *** [net/ipv4] Error 2
make[1]: *** [net] Error 2
make: *** [_all] Error 2

Peter
--
Peter Williams pwil3058@xxxxxxxxxxxxxx

"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/