Re: [PATCH] ohci1394 PCI fixup for Toshiba laptops

[Stefan Richter]

Jesse Barnes wrote:
> +static void __devinit pci_post_fixup_toshiba_ohci1394(struct pci_dev *dev)
> +{
> +	if (dmi_check_system(toshiba_ohci1394_dmi_table))
> +		return; /* only applies to certain Toshibas (so far) */
> +
> +	/* Restore config space on Toshiba laptops */
> +	mdelay(10);
> +	pci_write_config_word(dev, PCI_CACHE_LINE_SIZE, toshiba_line_size);

Shouldn't this read

        if (!dmi_check_system(toshiba_ohci1394_dmi_table))
                return;
            ^ ?

dmi_check_system returns the number of matches.
--
Stefan Richter
-=====-=-=-= =-=- ==--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/