Re: [PATCH] lib stringc cleanup restore useful memmove const

[Jesper Juhl]

On 10/25/05, Paul Jackson <pj@xxxxxxx> wrote:
> A couple of (char *) casts removed in a previous cleanup patch
> in lib/string.c:memmove() were actually useful, as they
> suppressed a couple of warnings:
>
Hmm, you are right, I shouldn't have missed that, my bad.


>         assignment discards qualifiers from pointer target type
>
> Fix by declaring the local variable const in the first place,
> so casts aren't needed to strip the const qualifier.
>
Looks good to me, thank you for fixing that up.


> Signed-off-by: Paul Jackson <pj@xxxxxxx>
Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>


--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/