Re: [PATCH 3/5] Swap Migration V4: migrate_pages() function

[Christoph Lameter]

On Wed, 26 Oct 2005, Dave Hansen wrote:

> Why is this #ifdef needed?  PageSwapCache() is #defined to 0 when !
> CONFIG_SWAP.

Right.

Index: linux-2.6.14-rc5-mm1/mm/vmscan.c
===================================================================
--- linux-2.6.14-rc5-mm1.orig/mm/vmscan.c	2005-10-26 09:46:20.000000000 -0700
+++ linux-2.6.14-rc5-mm1/mm/vmscan.c	2005-10-26 09:47:33.000000000 -0700
@@ -387,7 +387,6 @@ static inline int remove_mapping(struct 
 	if (unlikely(PageDirty(page)))
 		goto cannot_free;
 
-#ifdef CONFIG_SWAP
 	if (PageSwapCache(page)) {
 		swp_entry_t swap = { .val = page_private(page) };
 		add_to_swapped_list(swap.val);
@@ -397,7 +396,6 @@ static inline int remove_mapping(struct 
 		__put_page(page);	/* The pagecache ref */
 		return 1;
 	}
-#endif /* CONFIG_SWAP */
 
 	__remove_from_page_cache(page);
 	write_unlock_irq(&mapping->tree_lock);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/