Re: [PATCH] drivers/input/keyboard: convert to dynamic input_dev allocation

[Dmitry Torokhov]

On Friday 28 October 2005 01:55, Jan-Benedict Glaw wrote:
> On Thu, 2005-10-27 23:30:24 -0700, Greg KH <gregkh@xxxxxxx> wrote:
> > diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c
> > index 098963c..7f06780 100644
> > @@ -435,14 +434,14 @@ lkkbd_interrupt (struct serio *serio, un
> >  
> >  	switch (data) {
> >  		case LK_ALL_KEYS_UP:
> > -			input_regs (&lk->dev, regs);
> > +			input_regs (lk->dev, regs);
> >  			for (i = 0; i < ARRAY_SIZE (lkkbd_keycode); i++)
> >  				if (lk->keycode[i] != KEY_RESERVED)
> > -					input_report_key (&lk->dev, lk->keycode[i], 0);
> > -			input_sync (&lk->dev);
> > +					input_report_key (lk->dev, lk->keycode[i], 0);
> > +			input_sync (lk->dev);
> >  			break;
> >  		case LK_METRONOME:
> > -			DBG (KERN_INFO "Got LK_METRONOME and don't "
> > +			DBG (KERN_INFO "Got %#d and don't "
> >  					"know how to handle...\n");
> >  			break;
> >  		case LK_OUTPUT_ERROR:
> 
> The format change (%#d) should take an argument on stack, shouldn't
> it? But there's nothing pushed? ...or is it just a typo?
>

I think I messed it up... Was probably trying to do "default" case and then
reverted back. Will fix.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/