Re: [PATCH] Disable the most annoying printk in the kernel

[Pavel Machek]

Hi!

> > > > Remove most useless printk in the world
> > > 
> > > It warns about crappy keyboards. It triggers regulary for me on x32,
> > > (probably because of my weird capslock+x+s etc combination). It is
> > > usefull as a warning "this keyboard is crap" and "no, bad mechanical switch
> > > is not the reason for lost key".
> > 
> > Okay, if you want a message to remind you that your keyboard is crap
> > several times a day, please keep your own patch to do so.  Let the
> > rest of the world go with Andi's patch.
> 
> Plus keyboards are a dime a dozen these days, they give you one with
> every server whether or not you want it.  If you have rack full of 1U
> servers the pile of keyboards will be as high as the rack.  I wish our
> KVM vendor would come haul them away.

Well, keyboard detected and reported an error. Kernel reacted with
printk(). You are removing that printk(). I can understand that,
printk is really annoying, but I really believe _some_ error handling
should be added there if you remove the printk.
								Pavel
-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/