[PATCH] slab: Use same schedule timeout for all cpus in cache_reap

From: Manfred Spraul
Date: Sat Oct 29 2005 - 06:35:09 EST


Chen noticed that cache_reap uses REAPTIMEOUT_CPUC+smp_processor_id() as the timeout for rescheduling.
The "+smp_processor_id()" part is wrong, the timeout should be identical for all cpus: start_cpu_timer already adds a cpu dependant offset to avoid any clustering.
The attached patch removes smp_processor_id().

Signed-Off-By: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> --- 2.6/mm/slab.c 2005-10-29 13:17:44.000000000 +0200
+++ build-2.6/mm/slab.c 2005-10-29 13:18:14.000000000 +0200
@@ -3276,7 +3276,7 @@

if (down_trylock(&cache_chain_sem)) {
/* Give up. Setup the next iteration. */
- schedule_delayed_work(&__get_cpu_var(reap_work), REAPTIMEOUT_CPUC + smp_processor_id());
+ schedule_delayed_work(&__get_cpu_var(reap_work), REAPTIMEOUT_CPUC);
return;
}

@@ -3345,7 +3345,7 @@
up(&cache_chain_sem);
drain_remote_pages();
/* Setup the next iteration */
- schedule_delayed_work(&__get_cpu_var(reap_work), REAPTIMEOUT_CPUC + smp_processor_id());
+ schedule_delayed_work(&__get_cpu_var(reap_work), REAPTIMEOUT_CPUC);
}

#ifdef CONFIG_PROC_FS