Re: [PATCH] bluetooth hidp is broken on s390

[Al Viro]

On Sat, Oct 29, 2005 at 01:05:49PM +0200, Marcel Holtmann wrote:
> Hi Al,
> 
> > 	Bluetooth HIDP selects INPUT and it really needs it to be
> > there - module depends on input core.  And input core is never
> > built on s390...  Marked as broken on s390, for now; if somebody
> > has better ideas, feel free to fix it and remove dependency...
> > 
> > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> 
> basically I think someone should fix the input layer on S390, but I am
> fine with your fix.

There's a problem with that patch, though ;-/  S390 is never defined by
arch/s390/Kconfig; ARCH_S390 is.  From the fast grep it looks like there
is one more place with the same problem: drivers/char/Kconfig has
config HW_CONSOLE
        bool
        depends on VT && !S390 && !UML
        default y
and the second term is always true here.  Why do we have that dependency,
anyway, when s390 doesn't include drivers/char/Kconfig at all?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/