Re: [PATCH] ppc64: add MODALIAS= for vio bus

From: Olaf Hering
Date: Mon Oct 31 2005 - 02:41:15 EST


On Mon, Oct 31, Stephen Rothwell wrote:

> Hi Olaf,
>
> This patch breaks lagacy iSeries i.e. it won't link (iSeries has no get_property()).
> It may be easier to redo this patch against Paulus' merge tree.

Can you fix it up, why is there no get_property for iseries, yet?
iseries_veth should be autoloaded in a similar way.
Maybe it should just go into a CONFIG_PSERIES or whatever.

> A couple of trivial comments:
>
> On Sun, 30 Oct 2005 22:39:00 +0100 Olaf Hering <olh@xxxxxxx> wrote:
> >
> > +static int pseries_vio_hotplug (struct device *dev, char **envp, int num_envp,
> ^
> No space here, please.
>
> > + length = scnprintf (buffer, buffer_size, "MODALIAS=vio:T%sS%s",
> ^
> No space here either, please.

I copied it from macio_asic.c.


--
short story of a lazy sysadmin:
alias appserv=wotan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/