Re: [PATCH] DRM: 64-bit warning in compilation: wrong param size inDRM or harmless?

[Dave Airlie]

> I got a warning and while going to fix it, I discovered some issues with the
> code (including raciness).
>
> While compiling 2.6.14 for x86_64, I got:
>
>   CC [M]  drivers/char/drm/drm_bufs.o
> /home/paolo/Admin/kernel/6/VCS/linux-2.6.14/drivers/char/drm/drm_bufs.c: In
> function `drm_addmap_ioctl':
> /home/paolo/Admin/kernel/6/VCS/linux-2.6.14/drivers/char/drm/drm_bufs.c:309:
> warning: cast to pointer from integer of different size
> /home/paolo/Admin/kernel/6/VCS/linux-2.6.14/drivers/char/drm/drm_bufs.c:309:
> warning: cast to pointer from integer of different size
> /home/paolo/Admin/kernel/6/VCS/linux-2.6.14/drivers/char/drm/drm_bufs.c:309:
> warning: cast to pointer from integer of different size
> /home/paolo/Admin/kernel/6/VCS/linux-2.6.14/drivers/char/drm/drm_bufs.c:309:
> warning: cast to pointer from integer of different size

This is already fixed in the -mm tree from my -git archive.. I'll push it
to Linus this weekend hopefully..

> * If we _ever_ have more drm_device_t, the call to HandleId() would be
> racy.  Right?

Potentially it might be alright, I suppose I could move the handle base
into the drm device, in practice we won't hit this yet, as the X server is
the only client that can do this stuff.. and it doesn't do threading..

Dave.

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
Linux kernel - DRI, VAX / pam_smb / ILUG

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/