Re: [PATCH 17/20] inflate: mark some arrays as initdata

[Russell King]

On Mon, Oct 31, 2005 at 03:11:21PM -0800, Matt Mackall wrote:
> On Mon, Oct 31, 2005 at 11:10:52PM +0000, Russell King wrote:
> > That's what threading is for. 8)
> 
> What's what's threading is for?
> 
> > > I think for ARM, we can simply do -DINITDATA=const, yes?
> > 
> > No, unless you want to make this const:
> > 
> > -static u8 window[0x8000]; /* use a statically allocated window */
> > +static u8 INITDATA window[0x8000]; /* use a statically allocated window */
> 
> Ok, that bit can just be dropped. It needn't be INITDATA anyway, as it
> now gets kmalloc'ed for users in the kernel proper. Anything else?

I didn't notice anything else, but it will need testing on ARM in
this configuration.

Basically, for the decompressor to work in this mode, we have to
ensure:

1. no static data
2. no initialised non-const data

gets placed into the decompressor.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/