Re: [PATCH 01/37] dvb: dst: Correcty Identify Tuner and Daughterboards

[Manu Abraham]

Andrew Morton wrote:

> Manu Abraham <manu@xxxxxxxxxxx> wrote:
>  
>
> > Andrew Morton wrote:
> >
> >    
> >
> > > Michael Krufky <mkrufky@xxxxxxx> wrote:
> > >
> > >
> > >      
> > >
> > > > +static int dst_get_tuner_info(struct dst_state *state)
> > > > +{
> > > > +	u8 get_tuner_1[] = { 0x00, 0x13, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> > > > +	u8 get_tuner_2[] = { 0x00, 0x0b, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> > > > +
> > > > +	get_tuner_1[7] = dst_check_sum(get_tuner_1, 7);
> > > > +	get_tuner_2[7] = dst_check_sum(get_tuner_2, 7);
> > > > +	if (state->type_flags & DST_TYPE_HAS_MULTI_FE) {
> > > > +		if (dst_command(state, get_tuner_2, 8) < 0) {
> > > > +			dprintk(verbose, DST_INFO, 1, "Unsupported Command");
> > > > +			return -1;
> > > > +		}
> > > > +	} else {
> > > > +		if (dst_command(state, get_tuner_1, 8) < 0) {
> > > > +			dprintk(verbose, DST_INFO, 1, "Unsupported Command");
> > > > +			return -1;
> > > > +		}
> > > > +	}
> > > > +	memset(&state->board_info, '\0', 8);
> > > > +	memcpy(&state->board_info, &state->rxbuffer, 8);
> > > >   
> > > >
> > > >        
> > > The memset is unneeded...
> > >
> > >
> > >      
> > Hello Andrew,
> >
> > I will have that changed in dvb-kernel CVS. Would you like me to send in 
> > a patch for the same. Or you can have it changed .. ?
> >
> >    
>
> There's certainly no rush ;)  Please just add it to the 2.6.16 to-do list.
>
>  

Ok, done. I will queue it up in the TODO list for 2.6.16.


Thanks,
Manu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/