Re: [PATCH] backup timer for UARTs that lose interrupts

[Alex Williamson]

On Thu, 2005-11-10 at 10:44 +0000, Russell King wrote:

> Ok, would you mind fixing the patch so it isn't screwing up the
> default use of up->timer please?  You may notice that this timer
> is already used, and overwriting up->timer.function is a one-way
> process in your patch (which kills off the point of serial8250_timeout).

   I return up->timer.function to serial8250_timeout in the polling mode
path of serial8250_startup().  The patch only makes use of up->timer
when it's not already being used for polling and will restore it on the
next startup if the UART is switched to polling.  Would you prefer that
I always set up->timer.function to serial8250_timeout on the shutdown
path?  Thanks,
	
	Alex

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/