Re: [PATCH 1/10] Cr4 is valid on some 486s

[Gerd Knorr]

Roland Dreier wrote:
>     > +#define alternative_smp(smpinstr, upinstr) asm(upinstr, ##input)
>
> this wouldn't build with CONFIG_SMP=n -- you forgot the input param here.

Yep, and I've noticed meanwhile that it becomes quite messy if you try 
to do that with asm instructions which have both input and output 
parameters.  One way around that would be to use named parameters in the 
inline assembler.  Problem with that is that only gcc >= 3.1 understands 
those and at the moment the minimun requited compiler for the kernel 
still is gcc 2.95.3 according to Documentation/Changes ...

Is it an option to raise the required gcc version to 3.x, given that 
even Debian/stable ships with gcc 3.3 these days?

cheers,

  Gerd

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/