RE: bugs in /usr/src/linux/net/ipv6/mcast.c

From: Cipriani, Lawrence V (Larry)
Date: Wed Nov 16 2005 - 17:28:51 EST



Actually on this one

-------------------------------------------------

/usr/src/linux/abi/svr4/misc.c: extra semicolon near line 564:

for (p = tmp; *p; p++); !!!
p--;

It's fine the way it is, it would be easier to read if was this instead

for (p = tmp; *p; p++);
p--;

but no big deal.
-----------------------------------------------------------

Larry

-----Original Message-----
From: David S. Miller [mailto:davem@xxxxxxxxxxxxx]
Sent: Wednesday, November 16, 2005 4:02 PM
To: lvc@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: bugs in /usr/src/linux/net/ipv6/mcast.c


From: "Cipriani, Lawrence V (Larry)" <lvc@xxxxxxxxxx>
Date: Wed, 16 Nov 2005 09:53:07 -0500

> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 609
> if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i >= psl->sl_count)
> rv = 0;
>
> /usr/src/linux/net/ipv6/mcast.c: extra semicolon near line 611
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
> rv = 0;
> should be:
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
> rv = 0;

These have been fixed for a while now in 2.6.x
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/