Re: PATCH: Fix poor pointer math in devinet_sysctl_register

[David S. Miller]

From: Andrew Morton <akpm@xxxxxxxx>
Date: Wed, 16 Nov 2005 22:14:12 -0800

> "Jordan Crouse" <jordan.crouse@xxxxxxx> wrote:
> >  @@ -1454,7 +1454,7 @@ static void devinet_sysctl_register(stru
> >   		return;
> >   	memcpy(t, &devinet_sysctl, sizeof(*t));
> >   	for (i = 0; i < ARRAY_SIZE(t->devinet_vars) - 1; i++) {
> >  -		t->devinet_vars[i].data += (char *)p - (char *)&ipv4_devconf;
> >  +		t->devinet_vars[i].data += (int)((char *)p - (char *)&ipv4_devconf);
> 
> Confused.  These appear to be equivalent (on 32-bit CPUs, anyway).

Indeed, please describe the exact failure case when posting
such patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/